Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 - Rename payload folder to interfaces and deleted unused redirect button #656

Merged
merged 4 commits into from
Sep 17, 2024
Merged

V3 - Rename payload folder to interfaces and deleted unused redirect button #656

merged 4 commits into from
Sep 17, 2024

Conversation

anemne
Copy link
Contributor

@anemne anemne commented Sep 17, 2024

Short Description

This PR cleans up the code by refactoring and removing unused parts. This is done to improve readability and maintainability.

The changes I've done:

  • Deleted the button for redirect to shared studio. We don't need this with the workspace selector, and can not think of a case where we need this button.
  • I've moved some files in src into a slug folder.
  • Renamed payloads to interfaces and updated all imports.

Checklist

Please ensure that you’ve completed the following checkpoints before submitting your pull request:

  • Documentation: Relevant documentation has been added or updated (if applicable).
  • Testing: Have you tested your changes thoroughly?
    • Please list the types of tests you've run (unit, integration, manual, etc.):

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 9:17am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 9:17am

mathiazom
mathiazom reviewed Sep 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
christinaroise
christinaroise approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@christinaroise christinaroise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename the PR title to "Rename payload folder to interfaces"

README.md Outdated Show resolved Hide resolved
@anemne @mathiazom
Update README.md
8ec3a41 
Co-authored-by: Mathias Oterhals Myklebust <[email protected]>
@anemne anemne changed the title V3 cleanup studio web V3- Rename payload folder to interfaces Sep 17, 2024
@anemne anemne changed the title V3- Rename payload folder to interfaces V3 - Rename payload folder to interfaces and deleted unused redirect button Sep 17, 2024
@anemne anemne merged commit 67361c0 into v3 Sep 17, 2024
6 checks passed
@anemne anemne deleted the v3-cleanup-studio-web branch September 17, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinaroise christinaroise christinaroise approved these changes

@mathiazom mathiazom mathiazom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anemne @mathiazom @christinaroise